Michaël Zasso
Michaël Zasso
Access granted
I think we keep access requests open until access is revoked
According to https://github.com/chalk/supports-color/blob/ae809ecabd5965d0685e7fc121efe98c47ad8724/index.js#L126-L129, the only way to enable colors support by default on CI hosts is to hardcode them.
Wait, we already have the hardcoded CI variables: https://github.com/nodejs/node/blob/fca4107e76f0931ecfb6f90e7ad41bfd298e1e71/lib/internal/tty.js#L161-L174 This might actually be a bug in `util.styleText` after all.
There's something really weird here. According to the package's config, the file `preset.js` should never be loaded: https://github.com/storybookjs/addon-webpack5-compiler-babel/blob/014263d886370a09a88783257f911ad33db36502/package.json#L25-L33
> Current we check if the molecule was edited by using idCode. This is wrong. We use molfile v3000 (and we don't check if it changed): https://github.com/cheminfo/nmrium/blob/776deabbee26425d4316414eea5dea232acafbfd/src/component/modal/MoleculeStructureEditorModal.tsx#L56-L62 I updated OCL...
We could add a "stopPropagation" to the OCL editor but it's not even sure we listen to the same events. Normally it's up to the event listener to only handle...
It should not be based on where the mouse is located, but on the value of `event.target`
`[email protected]` sets a custom attribute on the root editor element: https://github.com/cheminfo/openchemlib-js/pull/305