Michaël Zasso
Michaël Zasso
@ronag @anonrig It seems that something changed with the fast API which results in fast C++ functions not being called when they expect `FastOneByteString` arguments (I verified the tests with...
Either fast API is "broken", or the strings used in the test are no longer of the kind "fast one-byte".
I'm trying to upstream a fix for the MSVC error: https://chromium-review.googlesource.com/c/v8/v8/+/5878257
Updated https://github.com/nodejs/node/pull/55014/commits/e68b2f6b9c82a37fe70c445c09526abceb2a40f2 to fix the `typename` error.
https://ci.nodejs.org/job/node-test-commit-osx-arm/16970/
This PR requires newer macOS versions in CI.
As far as I know, yes
Undrafted to check CI
Here are the places where we use it: ``` [51/238] CXX obj/src/libnode.node_buffer.o ../../src/node_buffer.cc:969:19: warning: 'Value' is deprecated: Prefer using String::ValueView if you can, or string->Write to a buffer if you...
Previous discussion: https://github.com/nodejs/admin/issues/53