Michaël Zasso
Michaël Zasso
> In https://ci.nodejs.org/job/node-cross-compile/configure there's some scripting that's supposed to add to the known_hosts Do you know why it's not added by Ansible?
CI passed. Can I have another review to land?
I think the cause is https://github.com/nodejs/node/pull/53627, but this issue is not about the regression itself. It's about the fact that CITGM somehow reported successful runs instead of failures.
@nodejs/build-infra I believe this is an issue with the Jenkins job. If I run `node bin/citgm-all.js --includeTags binary-split`, I can reproduce the regression and it correctly exits with code 1.
That's better, thanks ! Now do we need to investigate why it "thinks" there are no results ?
Here's the `report.xml` I get with Node.js 22.5.0 using the following command: `node bin/citgm-all.js --includeTags binary-split -x $PWD/report.xml` ``` [email protected] test > standard --verbose && node test.js npm error Exit...
I get the notable changes from https://chromestatus.com/roadmap. There's nothing about disposable there (and `using` still triggers a syntax error), why do you expect it to be available?
Probably. The tracking issue is still open: https://issues.chromium.org/issues/42203506
@nodejs/platform-windows MSVC complains: ``` 23:17:25 C:\workspace\node-compile-windows-debug\node\deps\v8\src\interpreter\interpreter-generator-tsa.cc(333,1): error C2872: 'Block': ambiguous symbol [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_initializers.vcxproj] 23:17:25 C:\workspace\node-compile-windows-debug\node\deps\v8\src\ast\ast.h(318,7): message : could be 'v8::internal::Block' [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_initializers.vcxproj] 23:17:25 C:\workspace\node-compile-windows-debug\node\deps\v8\src\compiler\turboshaft\graph.h(306,7): message : or 'v8::internal::compiler::turboshaft::Block' [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_initializers.vcxproj] 23:17:25 C:\workspace\node-compile-windows-debug\node\deps\v8\src\interpreter\interpreter-generator-tsa.cc(333,1): error...