Michaël Zasso
Michaël Zasso
That was introduced in https://github.com/nodejs/node/pull/19794 with the comment "against CRIME attack" in the code.
On `main`, we have comp.h: https://github.com/nodejs/node/blob/9bbbe60f6b0001964cb62182ce17e7f3980ccf06/deps/openssl/openssl/include/openssl/comp.h
@jasnell > > Ummmm..... good lord. It's going to be quite difficult to review this, unfortunately. The GitHub UI hangs and crashes whenever I try to open the changes tab....
Apart from https://github.com/nodejs/node/pull/57795/commits/2d17835293f2ace9e2cd47d094b095a272b31ba6, the other commits only touch `deps/openssl` and are entirely auto-generated by the update script.
New problems: ``` ../../deps/openssl/openssl/providers/implementations/signature/ml_dsa_sig.c:21:10: fatal error: 'prov/der_ml_dsa.h' file not found 21 | #include "prov/der_ml_dsa.h" | ^~~~~~~~~~~~~~~~~~~ ... ../../deps/openssl/openssl/providers/implementations/signature/slh_dsa_sig.c:17:10: fatal error: 'prov/der_slh_dsa.h' file not found 17 | #include "prov/der_slh_dsa.h" | ^~~~~~~~~~~~~~~~~~~~...
It's weird. https://github.com/nodejs/node/pull/57835 is included in the last force-push of this PR, which was generated by the update workflow on my fork.
https://github.com/targos/node/actions/runs/14438290543/job/40483070056
Ah, that's for OpenSSL 3.0. I didn't think about testing my change with it, sorry! Can we maybe do the update to 3.5 without the revert and only prevent the...
I could extend the end date, but I think it's more readable now and two years should be enough.
Just looked at the diff again and realized that `master` is back.