Michaël Zasso
Michaël Zasso
Merged, released, and updated the svg
I removed the reverts. It's not sustainable to keep them. Let's wait for https://github.com/nodejs/build/issues/4083 to be done.
@danmcd the [illumos patch](https://github.com/nodejs/node/commit/838e2332a5feb3c4fa703fd22c64200acdc78463) doesn't apply anymore so I had to skip it, but SmartOS still fails to build: https://ci.nodejs.org/job/node-test-commit-smartos/60903/nodes=smartos23-x64/
@nodejs/platform-aix PTAL at https://ci.nodejs.org/job/node-test-commit-aix/57505/nodes=aix72-ppc64/console ``` 18:58:48 ../deps/v8/src/objects/feedback-vector.cc: In member function 'void v8::internal::FeedbackVector::ClearOptimizedCode()': 18:58:48 ../deps/v8/src/objects/feedback-vector.cc:441:41: error: 'GetIsolate' was not declared in this scope; did you mean 'Isolate'? 18:58:48 441 | set_maybe_optimized_code(ClearedValue(GetIsolate()));...
Thanks @abmusse, @danmcd. I included both of your patches.
It's still blocked on macOS (new version is needed in Jenkins CI)
Failure is a timeout: ``` ✖ test/issue-3356.js (30002.591792ms) 'test timed out after 30000ms' ```
It's not specific to citgm. It fails very consistently on my own machine, just by running `npm run test:unit`
Note that it only times out if run with other tests. I cannot reproduce by running `node test/issue-3356.js` directly.
@anonrig you should like this :)