Tony Arcieri
Tony Arcieri
See also: #537 The upcoming [`bigint_helper_methods`](https://github.com/rust-lang/rust/issues/85532) feature of `core` defines method names and type signatures which it would be good to adopt here as well where it makes sense. Here's...
The CSR builder is called [`x509_cert::builder::RequestBuilder`](https://docs.rs/x509-cert/0.3.0-pre.0/x509_cert/request/index.html). It's located outside of [`x509_cert::request`](https://docs.rs/x509-cert/0.3.0-pre.0/x509_cert/request/index.html) and doesn't have CSR anywhere in its name, nor is it mentioned in the `request` module. cc @baloo
The implementation provided here is incomplete at best. The `jose` crate uses @RustCrypto cryptography and provides a more complete implementation: https://github.com/minkan-chat/jose
We have several `decode_as` methods which currently take a `reader: &mut impl Reader, algorithm: Algorithm` in that order. Most of these are unreleased outside of prereleases (`KeypairData::decode_as` is the only...
I just noticed [`ml-dsa` v0.1.0-pre.0](https://crates.io/crates/ml-dsa/0.1.0-pre.0) is 1.44MB in size due to the `.json` files for KATs/test vectors. Perhaps we could omit these from the published crate to reduce its size?...
Currently field elements are represented internally as [`Uint`](https://docs.rs/crypto-bigint/latest/crypto_bigint/struct.Uint.html), however those `Uint`s are generally constrained to the set of valid field elements for a given modulus represented in Montgomery form, namely...
Decaf x-coordinates are supposed to be serialized as 56-bytes, but we're serializing them as 57-bytes, with a TODO to fix this: https://github.com/RustCrypto/elliptic-curves/blob/c797d60/ed448-goldilocks/src/decaf/affine.rs#L63-L68 This has turned into a blocker for this...
Currently we only support Montgomery form for field elements. #1191 would further solidify that. `p256` contains a handwritten `Scalar` implementation which uses canonical form w\ Barrett reduction as opposed to...
Rust 1.89 beta is now out and includes initial stabilizations of AVX-512 target features: https://github.com/rust-lang/rust/pull/138940 cc @silvanshade
I was looking at using `KeyInit` with `elliptic-curve`, but for that application we need to return an error in the event the deserialized integer for the key overflows the curve's...