SSH icon indicating copy to clipboard operation
SSH copied to clipboard

`decode_as` argument ordering

Open tarcieri opened this issue 1 year ago • 1 comments

We have several decode_as methods which currently take a reader: &mut impl Reader, algorithm: Algorithm in that order. Most of these are unreleased outside of prereleases (KeypairData::decode_as is the only one in the stable public API).

I'm wondering if this ordering should be reversed so the algorithm comes first, and it reads as decode_as(algorithm, ... rather than decode_as(reader, ...

cc @baloo

tarcieri avatar Nov 04 '24 16:11 tarcieri

I'm fine with either options

baloo avatar Nov 04 '24 17:11 baloo