Tony Arcieri

Results 2560 comments of Tony Arcieri

I'm thinking the best way to implement this is have one common implementation of `Polyval` which impls all the traits like `UhfBackend` as well as a common implementation of powers-of-H...

PKCS#1 is a format for RSA keys, not Ed25519 keys. You want PKCS#8. See: https://docs.rs/ed25519-dalek/2.1.1/ed25519_dalek/#pkcs8-key-encoding The fact you can call this at all is something of a quirk of the...

The trait impl is here: https://docs.rs/ed25519-dalek/latest/ed25519_dalek/struct.SigningKey.html#impl-EncodePrivateKey-for-SigningKey We should add an example to the documentation.

ed25519-dalek has moved to: https://github.com/dalek-cryptography/curve25519-dalek/tree/main/ed25519-dalek If you feel this issue has not yet been addressed, please request this issue be moved to that repo by leaving a comment, or open...

I would suggest following the existing pattern for the [`SigningKey`](https://docs.rs/ssh-key/0.7.0-pre.1/ssh_key/trait.SigningKey.html) trait and defining an `AsyncSigningKey` trait which bounds on [`AsyncSigner`](https://docs.rs/async-signature/0.6.0-pre.4/async_signature/trait.AsyncSigner.html). Then you can add a `certificate::Builder::sign_async` method. This is similar...

Is there a particular use case you have in mind where you need access to the raw stream cipher? In the case of `aes-gcm`, it's to allow customization of the...

Can you provide a code example? I can't tell if what you're describing just needs a re-export of the `cipher` crate, as opposed to re-exporting the raw stream ciphers

It sounds like all you need is for it to re-export the `cipher` crate

We can add `cipher` re-exports where it makes sense

[NIST SP 800-38D](https://csrc.nist.gov/publications/detail/sp/800-38d/final) Appendix C provides guidelines for the use of short tags, noting the following potential attack up front: > Absent the requirements and guidelines in this appendix, it...