Tony Arcieri
Tony Arcieri
Ok, you linked to issues regarding fetching the crates index, hence my confusion
It looks like the tests are breaking on 32-bit platforms because you're hardcoding the number of limbs
@dvdplm can you remove the tests that overlap with proptests, or convert them to proptests where the existing proptests are lacking?
@dvdplm rebasing should fix the security audit
I'm generally fine with this, and the use cases are real
The build failure looks unrelated. I guess it's another warning that was recently added to the compiler? @mkj perhaps rebase if you haven't already. `main` should be clean
I'd be fine with either a separate feature or just putting it under `hazmat`, though I'm not sure what the benefit of the former would be over the latter
Exciting work! The parallelism would be prospectively quite helpful for https://github.com/RustCrypto/AEADs/issues/74 It'd be great if you could open a PR. Just looking over your code there are great code comments...
Note: I'd still invite someone to adapt the soft backend from https://github.com/ericlagergren/polyval-rs/ There are possible refactoring improvements from that implementation (e.g. extracting a proper `FieldElement` type) which would help for...
I took a look at adapting the field element multiplication from https://github.com/ericlagergren/polyval-rs/ and the result was slower than the existing BearSSL-derived implementation: ### polyval-rs ``` test bench1_10 ... bench: 33.88...