Tony Arcieri comments

Results 2560 comments of


                                            Tony Arcieri

aead: split `new_test!` into `new_pass_test!` and `new_fail_test!`

If we retain the current test vectors as opposed to the change in this PR, we can add a check that the output buffer does *not* match the plaintext on...

aead: split `new_test!` into `new_pass_test!` and `new_fail_test!`

If you do something other than returning the ciphertext, then we would need to change all of the two-pass implementations which abort early to mutate the buffer instead to make...

Remove incorrect comment about core_hint_black_box

Yeah, we should definitely add some more explanatory comments

Allow disabled SIMD support on x86_64 baremetal targets

That's surprising, because `cpufeatures` should already take care of this: https://github.com/RustCrypto/utils/pull/821

Make `Choice` and `CtOption` be `Hash`

What's the use case for `Choice` being `Hash`? You want to use a `Choice` as a key for a `HashMap`? I think all of these types, including and especially `BlackBox`,...

Expand `impl Encode for Vec<String>` to `impl Encode for Vec<E: Encode>`

@Eugeny can you open a PR?

Expand `impl Encode for Vec<String>` to `impl Encode for Vec<E: Encode>`

I will get to them soon, I am just going through a very, very large backlog

Expand `impl Encode for Vec<String>` to `impl Encode for Vec<E: Encode>`

I think some marker trait which denotes that encoding a message this way is actually valid for a given type would be helpful, and may even get rid of the...

CertificateBuilder running example

It's a working doctested example. I think perhaps the real problem you're referring to is the `rsa_signer()` function being hidden?

Add partial precomputation support

@AaronFeickert there's a large backlog of PRs it's going to take awhile to work through