Tony Arcieri
Tony Arcieri
Re: `cfg` gating, I think the current gating is fine but we should definitely call it out the feature as experimental/unstable and note it may change in future releases of...
Weeks (or less) if you want to get it into an unstable release, depending on the quality of the PR
(I would personally love to see traits for tweakable block ciphers land finally)
Maybe https://github.com/RustCrypto/traits/issues/177 is a better place for these discussions?
Upon further reflection, 270 days seems kind of arbitrary. 90 days has a lot of precedent, e.g. responsible disclosure windows. Perhaps we should go to 1 year (365 days)?
I also don’t really care. Randos said 90 days was too short but is the industry-wide standard disclosure period for vulnerabilities. A year felt less arbitrary than 270 days. But...
Looks like some build failures
It would be nice if these changes could be done in a purely additive manner with any breaking changes as a last resort and kept as minimal as possible. This...
Note that `mod.rs` is the older, Rust 2015 convention, and we use the newer Rust 2018 convention with files named after their respective modules: https://doc.rust-lang.org/edition-guide/rust-2018/path-changes.html#no-more-modrs Please don't use `mod.rs`, and...
> For the base group, dubbing the file 'attack_vector.rs', instead of 'av' is clear about its purpose, especially because there are many files such as 'ac', 'av', etc. @gildub you...