Tarang Jain comments

Results 116 comments of


                                            Tarang Jain

[FEA] Reduce memory pressure in HDBSCAN all_points_membership_vectors (or provide/link to best practices)

I think there might be two culprits here: 1. Allocating the membership vectors itself: for topic modeling tasks, we have observed that there are a large number of clusters and...

Accept RandomState object in RandomForestClassifier() and RandomForestRegressor

@cjnolet I merged it again with `branch-22.08` without force pushing.

Accept RandomState object in RandomForestClassifier() and RandomForestRegressor

rerun tests

[FEA] All points membership vector for HDBSCAN

rerun tests

[BUG] terminate called after throwing an instance of 'raft::cuda_error'

I was able to reproduce both @beckernick's error and @cjnolet's error by tweaking the `arange` parameter. I agree with @cjnolet's analysis because of the repeated zero-weight edges in the KNN....

[BUG] terminate called after throwing an instance of 'raft::cuda_error'

@MartinKlefas Have you tried to increase `min_samples`? Adding non-zero edges to the KNN should lead to convergence. If you can compute the maximum number of repeated inputs in your dataset...

RAFT-IVF support additional parameters, and features

Thanks for this issue. Linking https://github.com/facebookresearch/faiss/issues/3243

RAFT-IVF support additional parameters, and features

- Change default setting for `use_raft` in `GpuDistance.h` to true if RAFT is enabled. - Boolean helper to check if the current index is a raft index.

Add FAISS with RAFT enabled Benchmarking to raft-ann-bench

/ok to test

Add FAISS with RAFT enabled Benchmarking to raft-ann-bench

/ok to test