cuml icon indicating copy to clipboard operation
cuml copied to clipboard
verified publisher icon rapidsai

Accept RandomState object in RandomForestClassifier() and RandomForestRegressor

Open tarang-jain opened this issue 3 years ago • 7 comments

  • [x] Updated randomforestclassifier.pyx for accepting numpy.random.RandomState, cupy.random.RandomState and numpy.random.Generator objects in addition to accepting integers for the random_state variable.
  • [x] Add tests
  • [x] Update documentation

tarang-jain avatar May 31 '22 15:05 tarang-jain

@tarang-jain, I had started reviewing this but it looks like there's many little changes unrelated to this PR (such as in the CI scripts). Can you try merging upstream 22.08 (without force pushing please)?

cjnolet avatar Jun 14 '22 15:06 cjnolet

@cjnolet I merged it again with branch-22.08 without force pushing.

tarang-jain avatar Jun 14 '22 17:06 tarang-jain

rerun tests

ayushdg avatar Jun 29 '22 22:06 ayushdg

rerun tests

ayushdg avatar Jul 05 '22 16:07 ayushdg

rerun tests

tarang-jain avatar Jul 08 '22 16:07 tarang-jain

rerun tests

ayushdg avatar Jul 25 '22 22:07 ayushdg

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

github-actions[bot] avatar Aug 24 '22 23:08 github-actions[bot]