raft icon indicating copy to clipboard operation
raft copied to clipboard

Add FAISS with RAFT enabled Benchmarking to raft-ann-bench

Open tarang-jain opened this issue 2 years ago • 16 comments

  • [x] RMM pooled resource for RAFT enabled FAISS
  • [x] Update yaml config for faiss_gpu_ivf_flat, faiss_gpu_ivf_pq
  • [x] Small fix FAISS GPU IVFPQ params
  • [x] Update get_faiss.cmake
  • [x] Fix SIGSEGV

Notes: The StandardGpuResources object is part of FAISS' index classes. As a result, there is no way of creating a separate Raft handle for each thread without creating a new instance of the whole index object for a new thread. As such, multi-threaded benchmarking for GPU indices will not work. For CPU indices, @divyegala had seen some other issues. Though this PR is mainly about raft-enabled FAISS GPU indices.

tarang-jain avatar Nov 29 '23 16:11 tarang-jain

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

copy-pr-bot[bot] avatar Nov 29 '23 16:11 copy-pr-bot[bot]

/ok to test

cjnolet avatar Jan 11 '24 19:01 cjnolet

/ok to test

cjnolet avatar Jan 17 '24 12:01 cjnolet

/ok to test

tarang-jain avatar Jan 18 '24 12:01 tarang-jain

/ok to test

cjnolet avatar Feb 02 '24 22:02 cjnolet

/ok to test

cjnolet avatar Feb 13 '24 15:02 cjnolet

/ok to test

cjnolet avatar Feb 13 '24 15:02 cjnolet

/ok to test

cjnolet avatar Apr 10 '24 15:04 cjnolet

/ok to test

tarang-jain avatar Apr 23 '24 17:04 tarang-jain

/ok to test

tarang-jain avatar May 10 '24 23:05 tarang-jain

/ok to test

tarang-jain avatar May 11 '24 19:05 tarang-jain

/ok to test

tarang-jain avatar May 11 '24 23:05 tarang-jain

/ok to test

tarang-jain avatar May 12 '24 01:05 tarang-jain

/ok to test

tarang-jain avatar May 12 '24 05:05 tarang-jain

/ok to test

tarang-jain avatar May 13 '24 17:05 tarang-jain

/ok to test

tarang-jain avatar May 13 '24 23:05 tarang-jain

/ok to test

tarang-jain avatar May 14 '24 18:05 tarang-jain

/ok to test

tarang-jain avatar May 21 '24 18:05 tarang-jain

/ok to test

tarang-jain avatar Jun 10 '24 21:06 tarang-jain

/ok to test

tarang-jain avatar Jun 10 '24 21:06 tarang-jain

/ok to test

tarang-jain avatar Jun 13 '24 15:06 tarang-jain

/ok to test

tarang-jain avatar Jun 13 '24 18:06 tarang-jain

/ok to test

tarang-jain avatar Jun 13 '24 20:06 tarang-jain

/merge

tfeher avatar Jun 17 '24 14:06 tfeher