Tamir Duberstein comments

Results 362 comments of


                                            Tamir Duberstein

Accessing "unset" value in array yields value with all zeros

Sure, want to send a PR?

aya-ebpf: introduce `array::OutOfBounds` error

> > this is a compelling argument against this change. now to retain ergonomics we're having to do this error-discarding nonsense. is it better? I'll let @alessandrod adjudicate. > >...

aya-ebpf: introduce `array::OutOfBounds` error

I am 👎 on this. Perhaps @alessandrod can weigh in.

SetupFilter: log an error if fallback curl fails

I'm glad to see this is being rebased; is it time to merge it please?

SetupFilter: log an error if fallback curl fails

@vitalied can we merge this please?

SetupFilter: log an error if fallback curl fails

@BanzaiMan could you TAL please?

SetupFilter: log an error if fallback curl fails

@smokodon I believe this is still relevant, even though the motivating failure is long gone.

SetupFilter: log an error if fallback curl fails

OK. 7 years is long enough.

feat: Added bounds check for `SkBuff::load_bytes` and relevant integration test.

@RyanAlameddine apologies for the delay. Seems you didn't actually reply to the review comments. Could you please do so, as well as rebase, and I'll have a look?

Fix or examples required for socket filter byte loading

Is it possible `ctx.skb.len` is zero? We might need a check for that. Ah I missed this: > I have tried adding a condition which early returns if ctx.len() <...