Tamir Duberstein
Tamir Duberstein
@tyrone-wu can you take a look at the failures here? This is based on #1266 which is green. Some of the failures are in code you added in #1063.
> I think i found a solution. I raised `RLIMIT_MEMLOCK` for the tests giving PermissionDenied with: > > ```rust > /// Raises `RLIMIT_MEMLOCK` to `RLIM_INFINITY` if it is not already...
Turns out we already emit a warning for this, made conditional in https://github.com/aya-rs/aya/commit/3d592d0f295b0a2c385e200bb0224c57c144f5ea. Should we bump RLIMIT unconditionally on these kernels?
With the latest changes, the feature detection tests are passing. Remaining failures: ``` failures: tests::btf_relocations::relocation_tests::crate_field_reloc_bpf_none_none_2_expects tests::btf_relocations::relocation_tests::crate_field_reloc_bpf_some_crate_field_reloc_btf_none_1_expects tests::btf_relocations::relocation_tests::crate_struct_flavors_reloc_bpf_none_none_1_expects tests::btf_relocations::relocation_tests::crate_struct_flavors_reloc_bpf_some_crate_struct_flavors_reloc_btf_none_2_expects tests::load::basic_tracepoint tests::load::basic_uprobe tests::load::pin_lifecycle_kprobe tests::load::pin_lifecycle_tracepoint tests::load::pin_lifecycle_uprobe tests::load::unload_kprobe tests::strncmp::bpf_strncmp tests::xdp::af_xdp tests::xdp::cpumap_chain ``` I spent...
@dave-tucker replies below: > First question, why do we run the same set of tests six times? Second question, each iteration of the test shares the same VM? We run...
@codex review
@codex review
Relatedly: is there a tracking issue for native `steam` support?
Should this be closed?
> Overall, I agree with @alessandrod, we shouldn't use `Option` as return values but `Option` instead (0 mapping to None) Why is that better? If we know they can't be...