Tamir Duberstein
Tamir Duberstein
@dave-tucker do you know if @Billy99 plans to return to this work?
Closing doesn't throw the code away, so I'm going to do that. Thanks!
Rebased this with regenerated API. @alessandrod does this require further changes?
I think you understood exactly right. virtme-ng isn't my project, but for better or for worse it is currently building completions at build time and packaging them in the distribution....
> Also, just to clarify, for pip packages, configuring things system-wide is discouraged _at install time_. You could still have a command like `my-python-app install-completions` that would install the static...
The tests updated in that PR contain the same diagnostic text e.g. https://github.com/rust-lang/rust/commit/b1774b8d7382325d2bb5cc518e463ae9d6de5898#diff-d26852ce626e7632e48fd9e08630bf948f008ef8f7de7b00336c6b9cb0eda19f
Ah, I posted this on the wrong PR, it was probably https://github.com/rust-lang/rust/pull/140553.
Thanks for the diagnosis. I've sent https://github.com/aya-rs/aya/pull/1271 to work around this in aya for now.
I won't speak for @alessandrod but IMO logging errors is not what we want to do here. We should instead propagate those errors, probably.
This has merge conflicts.