Daniel Richards

Results 215 comments of Daniel Richards

> I also considered this, but IMO this sort of UI only makes sense when you're rotating the cropping window itself, not the background image. Because this PR currently assumes...

> If we reflow(scale) the image after resizing then the image box will grow bigger to the point that it might be difficult to fit the box into the screen...

This works nicely so far, really great work here. There's a few little things I noticed from testing (you're probably aware some of them): - When engaging crop mode, there's...

Also related - https://github.com/WordPress/gutenberg/issues/58233

@up1512001 I'm not really sure I know the PHP code for the navigation block well enough or how the block is supposed to function in terms of that wrapper. I've...

This was also reported in #63795 There are a couple of PRs proposing fixes - https://github.com/WordPress/gutenberg/pull/63809 and https://github.com/WordPress/gutenberg/pull/63834

> This PR is fairly outdated at the moment. @talldan, do you think it still would be valuable to bring it to the finish line? I'm not sure I fully...

@carolinan Sorry, I missed the ping. The main thing is the inconsistency - regular (non-hover) colors and hover colors are working differently. It's really hard to say how the navigation...

Not that I disagree with the intent of preventing invalid markup, but this feature sounds like a bit of a minefield in terms of implementation. Any feature would have to...

Thanks for working on this. I agree with @getdave about opening it up to an arbitrary number of blocks. The design starts to look wrong with four. A filter could...