Daniel Richards

Results 215 comments of Daniel Richards

Thanks for the quick fix! It's looking good now. I guess we need to figure the best way to update the failing e2e tests. I haven't looked too closely into...

> It would be cool to allow different block types to use the same value if they share the same name. For instance I can add a "company name" bound...

> I am not sure why this isn't a problem with the current implementation in trunk. The implementation in `trunk` doesn't use `useEntityBlockEditor` so there can never be any edits...

> Just wanted to chime in, but I feel extensibility should be a high concern straight out of the gate. @ronalfy It'd be interesting to hear what kind of extensibility...

> This is "core/button", right? not "core/block"? Yes, I've updated it.

We're now in the RC phase of 6.6 and everything tracked has been completed or punted, so I'll close this issue. Smaller individual issues are being tracked on [the 6.6...

The rounded style for the image block looks a little different in this PR compared to trunk. This PR: ![Screenshot 2024-04-26 at 4 15 22 pm](https://github.com/WordPress/gutenberg/assets/677833/c89d01be-6063-4682-a189-3a4eab07c82e) Trunk: ![Screenshot 2024-04-26 at...

@swissspidy I'm actually starting to get the impression that the composer image being updated to PHP 8 is the cause of the recent issues rather than changes to the WordPress...

@youknowriad Given your comment about unifying patterns/template parts (https://github.com/WordPress/gutenberg/issues/62566#issuecomment-2180749161). I wonder if it might be an idea trying to use the existing `register_block_pattern` API (https://developer.wordpress.org/reference/functions/register_block_pattern/) for registering template parts? Otherwise...

Can probably adjust the padding around the patterns list, the left/right padding feels unnecessary and makes the previews much smaller than they need to be: Also looks like there's some...