Daniel Richards

Results 215 comments of Daniel Richards

There's also a report in trac of this - https://core.trac.wordpress.org/ticket/61592. Also noting some similarities with https://github.com/WordPress/gutenberg/issues/63713.

> The culprit of the infinite loop according to logs points to setAttributes() method inside componentDidMount(). If I add a check, the issue seems "solved", however this check is not...

> There's no infinite loop if I point value to blocks. @Mamaduka Yeah, this does seem to fix it, and I'm not seeing any issues with the functionality of the...

The terms only seem to be shown alphabetically visually, but are stored in order added in the database, so I think this is really a design issue rather than a...

I've reworded the title of this so that it can be treated as an enhancement. #22048 has been opened since and seems very similar.

> By the way, I saw that @stokesman submitted an issue in the Yoast SEO plugin repository. That issue details one example of how this PR affects plugin developers and...

> Yes we probably need to invent something new. I stumbled across this issue. Unless this has been solved since your comment, I think we do need something new. There...

@pryley What's the use case for such a callback?

Thanks for sharing @pryley. I like @kevin940726's idea.

I think @kevin940726 was referring to a new API that would be implemented in Gutenberg (as an alternative to having a callback prop).