Daniel Richards

Results 215 comments of Daniel Richards

It'd be good to not bring WordPress politics into the prettier repo. I don't think the devs here are really concerned with how decisions are made in WordPress. 😄 The...

Hi @LeoStaley, sorry for the late reply, didn't see your comment. Yep, this is pretty old, and the version of react could do with some updating. I'll take a look...

I've added https://github.com/WordPress/gutenberg/issues/42725 to the list. Hope that's ok!

> The popover's offset doesn't update when the block/pattern inserter is closed (https://github.com/WordPress/gutenberg/pull/42417#issuecomment-1198048684) (needs to be confirmed if the regression is caused by the refactor to floating UI) I think...

There are a couple of other issues here in the widgets customizer - [Popover component overlay not fully visible in Customizer](https://github.com/WordPress/gutenberg/issues/43678#top)

I think it happens whenever you drop on the empty space after the list of blocks. The same happens with normal block drag and drop, and list view uses most...

> For what it's worth that's how drop zones were implemented originally, and it was refactored (simplified I guess) to what it is today either by @talldan or @ellatrix I...

@youknowriad I did try setting that to `false` in a PR here - [Test popover animation frame performance](https://github.com/WordPress/gutenberg/pull/44604#top). The performance test isn't showing any difference - https://github.com/WordPress/gutenberg/actions/runs/3156955991/jobs/5137248278#step:5:101. Maybe I made...

> @talldan I didn't run the test so could be that I'm wrong in terms of "numbers" but when profiling, the browser is back to a decent state (idle time,...

I'm taking a look at persisted preferences.