Daniel Richards

Results 215 comments of Daniel Richards

I don't think Quote tests have been migrated yet, the old puppeteer tests are still present, and there are quite a lot of test cases that haven't been ported -...

@juhi123 I don't think that's a migration, just someone decided to write an individual test in playwright. The other test cases still need to be migrated.

This is possibly just a relic. It seems to have been introduced in this commit - https://github.com/WordPress/gutenberg/commit/23f8945f809c3477991c52dc12c3626dfa4b4178, and predates the scripts package. (cc @atimmer). Perhaps it was an experiment back...

BTW - I notice in WordPress core, the custom color popover is always to the left of the gradient popover (it seems anchored to the popover contents, judging by how...

> The limit with this system is that, as explained above, we are currently able to only pick between 2 "configurations" based on the isRenderedInSidebar check. I think there's the...

As mentioned in the PR it ended up being bigger than expected. I think all the changes are necessary, though in some cases there are multiple ways to solve the...

@alexstine Thanks. It should be ready for testing, but the code is liable to change until I've merged a few separate PRs. @getdave @scruffian First pure refactor PR in https://github.com/WordPress/gutenberg/pull/43057.

Second refactor PR - https://github.com/WordPress/gutenberg/pull/43081

There were some conflicts, so I've rebased this and solved them. https://github.com/WordPress/gutenberg/pull/42735 has since been merged, and that introduced more places where `NavigationMenuSelector` is shown, so I need to test...

Closing as this is now outdated and the UI has changed.