Daniel Richards

Results 215 comments of Daniel Richards

Thanks @zaguiini, yes that's another instance of the issue. It's hard to describe!

https://github.com/WordPress/gutenberg/pull/32776 may also have fixed some inconsistencies. > There's no indicator shown when trying to drag it above the first block. https://github.com/WordPress/gutenberg/pull/33024 should fix this. > There's no indicator shown...

As mentioned on https://github.com/WordPress/gutenberg/issues/43127, it looks like the fix in https://github.com/WordPress/gutenberg/pull/33024 has regressed, the indicator no longer shows above the first block. edit: Now fixed in #43135.

Thanks for mentioning it. I'll take a look. Also worth mentioning that the Buttons block is really messed up, that still shows vertical drop indicators 😬

That was a fairly easy fix - #43944. I'll add some end to end testing for this as well before making it ready for code review.

Thanks for the feedback @jameskoster - I'll get to work on making those changes.

Throughout development so far I've been focusing on launching a modal directly from the inserter menu item. An alternative simpler technical solution is to insert a template part block as...

@jameskoster I've pushed an iteration on this that includes most of the changes discussed. Template part naming doesn't quite do what @mtias mentioned yet, still looking into that one, but...

Thanks for the further feedback @jameskoster. I'll have a think about the best way to achieve that and let you know when I have something more to test.

> 1. Monolithic 'Header' block that allows selection of existing template parts and creation of new ones > 2. A 'New Header' block that opens the pattern modal > 3....