Results 393 comments of Thomas Leonard

I wonder how this close_tls system can work even for TLS 1.2. If you want to shut down a TLS connection but continue using the raw socket afterwards, then you'll...

> So you do a read and write at the same time on the same flow. Would you mind to point me to an application thereof? Most users of TLS...

> On the other side, in the recent 8 years of OCaml-TLS being used, there hadn't been such an issue with either Lwt or Async. Yes, it's very unlikely this...

I found this comment in one of the tests, but it would be good to document it somewhere sensible: https://github.com/ocaml-multicore/eio/blob/8f7f82d2c12076af8e9b8b365c58ebadaa963b8c/tests/domains.md#L194-L195 Possibly there should be a way to mark something as...

Since Eio always uses a domain manager to spawn new domains, you could wrap the default with one that copies some or all of the fiber-local values across. > this...

You probably don't want to copy all of `vars` anyway, just the ones you know are thread-safe. You could keep all of your programs vars in their own map and...

The simplest thing would be adding some kind of optional `Fiber.create_key ~share_on_domain_spawn:true ()` flag. Though declaring that all keys must be thread-safe is another possibility. One extra point though: people...

> I'll differ to @talex5's knowledge of which EAI_ errors to catch and which to no :)) I have no special knowledge - just reading the `getaddrinfo` man-page :-)

The tests need updating too (CI is failing).

Rebasing on `main` should fix most of the CI problems (see #808). The `ERROR while compiling mdx.2.5.0` on OCaml 5.4-alpha1 is due to https://github.com/realworldocaml/mdx/issues/469 and can be ignored.