Thomas Leonard

You should be able to do it in two steps: send the error (`Wl_display.error`) and then disconnect (`Server.stop`).

Though it might be that `stop` shuts the connection down before the queued error is sent. Possibly calling `stop` should add a stop message to `outbox` and have it shut...

A few thoughts on this: - We don't know if `recommended_domain_count` is a good number of domains. It depends what else the computer is doing. e.g. if you're running a...

> Isn't `recommended_domain_count` just the number of logical cores available on the system? Isn't it a good default in general to start that many domains ie operating system threads? As...

Looking at https://developer.mozilla.org/en-US/docs/Web/API/Window/requestAnimationFrame it seems that: - `aux` now gets a timestamp (float) - `requestAnimationFrame` now returns an ID You probably want something like `let rec aux ts = ...`...

> I feel like 99% of users will want `` `Or_truncate 0o666`. I'd say that's the least likely one. Typically you want: - `Exclusive` when you want to write a...

Agreed. If you want to make a PR, these lines need changing to use `raise (Eio.Process.err ...)`. https://github.com/ocaml-multicore/eio/blob/a6c0be9affd1793613e5e23bba4258c9f56d2c36/lib_eio_linux/low_level.ml#L524 https://github.com/ocaml-multicore/eio/blob/a6c0be9affd1793613e5e23bba4258c9f56d2c36/lib_eio_posix/low_level.ml#L288

The one in `process.mli` now uses `

Thanks for working on this! Currently the `tests` directory isn't run on Windows (I think due to https://github.com/realworldocaml/mdx/issues/295, though it's unclear what the problem is). `native` will indeed give different...

We already have: ```ocaml let read_all flow = Buf_read.(parse_exn take_all) flow ~max_size:max_int ``` Perhaps `if size = 0 then read_all flow` would do here?