Results 372 comments of Thomas Leonard

Thanks @mbarbin, that's a problem, indeed! Logically, a handler is a function like this: ``` type ('t, 'tags) handler = { fn : 'impl. ('t, 'impl, 'tags) pi -> 'impl...

Hmm, interesting. I'm wondering about another possibility: what if we require users to provide a function (as above, but returning an option), and convert it to an array in `Resource.handler`...

I think the thing that makes the documentation confusing is that it's not obvious that it is describing an "easy mode". e.g. > Rule 1 A function that has parameters...

Make sense. We already made this change for e.g. `Eio_unix.Net.import_socket_stream`. (and the Git version of cohttp-eio also relaxes the type for `respond`)

You might want to look at https://github.com/ocaml-multicore/eio/pull/744, which made the same change for sockets. In particular, take care of the difference between ``.

It's hard to see what changes with sections being moved and edited at the same time. It seems like this is combining three things: 1. Some obvious fixes, e.g. requiring...

Most of this was merged in #650, so closing.

I think the message is just saying that it timed out. That was added in https://github.com/ocurrent/obuilder/pull/130 ("Windows prereqs tests"). It doesn't seem surprising to me that a test might take...

Thanks - this is great! I pushed updates for tls-eio to https://github.com/talex5/ocaml-tls/commits/shutdown/ (needs review). The first commit just ports the changes to tls-lwt directly to tls-eio. The second removes the...