Jimmy Jia

Results 390 comments of Jimmy Jia

BTW, compare my PR adding this functionality to express-graphql.

IMO you should really share both `rootValue` and `context` across all queries in a batch... I guess depending on the semantics you want. Like really a "batched query" is just...

No, I mean that there's not really much reason to not _always_ share context and rootValue across all GraphQL requests in a batched HTTP request.

The duplication is a bit unfortunate, yeah. We pull in core-js because we use the runtime transform, and we use the runtime transform because this pulls in a (pure) polyfill...

But if you can think of a better way to package this, I'd be happy to not pull in these runtime polyfills.

I think the distinction here is that async iterators are a bit more exotic than the kinds of polyfills that React and Relay tend to use. Saying "you need to...

We might be able to use https://github.com/babel/babel/issues/3934#issuecomment-636190883 to omit some of the polyfills.

I just hit this. If someone can point me at the correct section in the docs to update, I can write up the docs update.

I'm still happy to write this up if I can get some pointers on which doc to update.

Hmm, so I actually have no idea what's missing in the docs. The use of `rediss://` appears to be documented, and the README explains the use of `ssl_cert_reqs` with ElastiCache:...