Taiki Endo
Taiki Endo
It seems that @cuviper has tried something similar to this before (https://github.com/indexmap-rs/indexmap/issues/253#issuecomment-1459160166). The approach there does not seem to have type inference issues unlike this PR? (or am I missed...
Nice! Could you revert the turbofish addition on crossbeam-skiplist/tests/map.rs and crossbeam-skiplist/tests/set.rs as well? https://github.com/crossbeam-rs/crossbeam/pull/1132/files#diff-75f4f67227e1c745e030de5d756b0cc4cb11ccd273aac4bd1cf8277d4c7abc30 https://github.com/crossbeam-rs/crossbeam/pull/1132/files#diff-83acf27b3801996150152093e109e25ebe594f6595ead4c9297986b1d0a3ec27
The first version of this PR was a breaking change because it required turbofish in some places, but I guess the current version will actually not cause the breakage that...
New release is blocked by what to do with https://github.com/crossbeam-rs/crossbeam/pull/1158.
I think such a change is a breaking change when done after this change is released. See https://github.com/tokio-rs/bytes/issues/479#issuecomment-1011065884 for more.
Unless [FusedIterator](https://doc.rust-lang.org/nightly/std/iter/trait.FusedIterator.html) is implemented, the behavior of iterator after returning None is not specified. That said, it is odd to cycle back to the first element.
- As for most `*linux-musl*` targets, static linking is currently enabled by default, so no additional thing is needed. - As for others, (if crt-static is respected by that target)...
> As for others, (if crt-static is respected by that target) you just need to set env vars. Ah, if you use `cross` (`upload-rust-binary-action@v1`'s default cross-compile tool), you may need...
> how to pass the env `RUSTFLAGS="-C target-feature=+crt-static"` in `taiki-e/upload-rust-binary-action@v1` without modify existed `Cargo.toml` for gnu target? There are two ways. - Append `RUSTFLAGS=...` to `GITHUB_ENV` as is done in...
You can use setup-cross-toolchain-action for other musl targets. (see https://github.com/taiki-e/upload-rust-binary-action?tab=readme-ov-file#setup-cross-toolchain-action) As for powerpc64le-unknown-linux-musl and riscv64gc-unknown-linux-musl, they are tier 2 at least on nightly, so they should work as others. As...