Taiki Endo

It is not clear if it is sufficient to disable it in the destructor of our type, since the problem appears to be happening in the destructor of thread-local storage....

I would like to merge only the part that makes tracing optional: - It's now necessary anyway because of the MSRV issue (https://github.com/smol-rs/async-io/pull/230#issuecomment-2971458543). - It's not clear that another part...

We currently have this only for binstall. https://github.com/taiki-e/install-action/blob/b28eee2bb643cb4606a986e802770206f53c5259/main.sh#L318-L326 The difficult point is that we need to handle the different formats of the version output well. For example, binstall changed it...

(There are also a number of tools that do not support version output...) https://github.com/taiki-e/install-action/blob/3e71e7135de310b70bc22dccb4d275acde8e055a/main.sh#L786-L811

> if command -v zola > /dev/null 2>&1; as the likely simplest and most robust. Well, this action cannot adopt this way because it is insufficient, at least for use...

> --skip_reinstall flag The "don't reinstall if we know it's the same version" is perfectly reasonable, and ideally I would like to implement that for all tools *by default*. And...

> implement [#577 (comment)](https://github.com/taiki-e/install-action/issues/577#issuecomment-2219713430) grep approach > ```text > --version | head -1 | grep -Eq "(^|[^0-9])${version_to_install//\./\\.}($|[^0-9])" > ^^^^^^^ > ``` Hmm, `head -1` before grep doesn't work with shellcheck...

As for tools that do not provide a way to output the version, I think we can ignore (always reinstall) them for now. (I feel it would make more sense...

> 4\. wait-for-them supports --help but still no version string to be found I found there is an open feature request to add --version flag: https://github.com/shenek/wait-for-them/issues/53

The checksum is for the archive, not the binary. Anyway, I think it will be slower than just calling version command.