Taiki Endo

Results 938 comments of Taiki Endo

Hmm, RawWaker docs say it consisted of a pointer and a vtable, so I thought it would never inline the data...

Thanks for finding this. > do we have any clear design constraints for this implementation (e.g. avoiding unsafe code, avoiding synchronous waiting, optimizing throughput with LIFO scheduling, or optimizing latency...

We can stabilize bilock once https://github.com/rust-lang/futures-rs/pull/2384 is merged.

The reason why we do not have this and it is difficult to add is because it may conflict with StreamExt::by_ref. It is possible to add this in 0.4 as...

I think we can probably support something like this: ```rust #[auto_enum(fmt::Debug)] fn f() -> Option { if ... { let opt = ...; // converted to `return opt.map(|some| Enum::A(some));` return...

This is a bug, but I'm not sure if it can be fully fixed.

This also affects doc-comment on fields (as that is actually`#[doc = "..."]` attributes).

Another case: https://github.com/taiki-e/pin-project-lite/pull/28#issuecomment-702176944 > * The `#[project]` (and `#[project_ref]`) attribute must precede the other attributes except for `#[doc]`: > > ```rust > pin_project! { > /// documents (`#[doc]`) can be...

Workaround: If the attribute is `#[doc]` (doc comment), this can be avoided by changing it to normal comment. ```diff pin_project! { #[derive(serde::Deserialize)] struct Struct1 { - /// description + //...

Note: This issue is about attributes that apply only to the original struct/enum. Proper handling of cfg/cfg_attr on fields and variants requires a more complex approach than the fix for...