Taiki Endo

Results 938 comments of Taiki Endo

Yeah, currently, it needs to use `future::ready` or async function. (Those problems will be fixed if async closure is improved.) (As it was updated to use async-await in https://github.com/rust-lang-nursery/futures-rs/pull/1843, futures's...

Yeah, current async closures are equivalent to closures which return async blocks.

IIRC, this crate's Stream trait is for documentation, so I think either one is fine.

> It seems I cannot have `async_std::bench` attribute even when I activate `attributes` feature See also https://github.com/async-rs/async-attributes/issues/9 and https://github.com/async-rs/async-std/issues/70#issuecomment-528042987

> Nix does not depend on Serde, but it's used by cargo-hack, I would suggest using `+stable` for cargo-hack installation or installing cargo-hack from GitHub release (like https://github.com/crossbeam-rs/crossbeam/pull/761 or https://github.com/tokio-rs/bytes/pull/507)...

> I thought about using +stable to build cargo-hack. But that would require installing two toolchains instead of one, slowing down CI. Ah, sorry, I missed that Cirrus CI does...

@sunfishcode Thanks for the PR! I'm basically agreed with merging this, but have a few questions. - Are there tests for [*outline*](https://github.com/bytecodealliance/rustix/tree/main/src/backend/linux_raw/arch/outline) asm implementations for x86/arm/riscv? I could not find...

@mike-kfed Great! > It can be used as a library, which is probably of interest to you. And, since I built this for you, I wait with releasing this to...

It might make sense to add a GitLab example to the ["Continuous Integration" section in readme](https://github.com/taiki-e/cargo-llvm-cov#continuous-integration) and mention the helper tool in it.

Added as `--cobertura` flag in 0.5.1 (#224). Thanks @mike-kfed for working on this!