Taiki Endo

Results 938 comments of Taiki Endo

> That doesn't help with StreamExt though - the std docs never mention any of the extension traits. you are right. copy of std is not enough, we need to...

> `futures-channel` is also a "utility crate", but it's almost independent, so I'm not sure if merging it is really preferable. Given that `futures-channel` currently depends on `futures-core`'s internal API,...

To make backporting to 0.3 easier, I will block this for now.

Thanks for the PR! What are the advantages of this over try_buffer_unordered and try_buffered?

If it is covered by an existing API, I'm going to close this in favor of that. Thanks anyway for the PR!

> Should it be re-exported as `ArcWake` to avoid breakage? Since the default methods for Wake and ArcWake are different, this is breaking change anyway, and the re-export as ArcWake...

Thanks for the report. The way good than yield per poll to fix this is to limit iterations. See https://github.com/tokio-rs/tokio/pull/3625 for more.

> There's a race between tasks to be the last to set the "write waker", and the losing task may never be able to be woken. Yeah, it can actually...

> > There's a race between tasks to be the last to set the "write waker", and the losing task may never be able to be woken. > > Yeah,...

Both renaming buffered/buffer_unordered and removing for_each_concurrent look like good ideas.