Taiki Endo

related: https://github.com/rust-lang/futures-rs/pull/2046

All existing `into_inner` methods discard the combinator state and return only the underlying stream. Any reason why this returns an own enum containing the state instead of returning the `Option`?...

@acfoltzer Thanks for your response. I think the motive makes sense, but I would prefer not to expose the internal representation of these combinators. So, I think it might be...

> I think this could even be applied to resolve the overlapping definitions of `Stream::next` and `StreamExt::next`. No, this is breaking change. If you have code that imports only `StreamExt`,...

(Marked as blocked until implemented in std. The API proposed in RFC has some issues and is likely to change when it is actually implemented in std.)

This depends on what the error returned is. If the error does not provide details or you do not check the content of the error, it is common to consider...

> If you are storing Shared to be reused (much along the same lines as the recent commit that adds the Weak Shared references), this makes a difference in allowing...

@afranchuk Thanks for clarifying. My main concern is that `Shared` is used as a future of shared value, not a future of shared future. I think `Shared` is not efficient...

(If this has enough documentation on performance (like mentioned in the previous comment), we may accept this, but we recommend that you avoid using it if possible.)

Even after the RFC has been merged, it can be changed with good reason, so it is a very difficult question at which stage to determine that. (The risk cannot...