Johann Tuffe comments

Results 173 comments of


                                            Johann Tuffe

Adding text vectorization

I'd personally love that!

libproxy support

> Do you think it would be possible to support libproxy in hyper-proxy? Definitely, under a dedicated feature to be sure people opt-in.

Accessing the underlying TLS stream

I would definitely consider it. I am on a very low bandwidth since some time now but I'd be happy to share ownership with someone if needed.

Hide inaccessible members and functions

@phildawes just to be sure, everything should be done in [matchers.rs](https://github.com/phildawes/racer/blob/master/src/racer/matchers.rs#L49) ? With `local` variable and `pub` keyword ?

Use iterator whenever possible instead of manual iteration

I agree with @JustForFun88. I don't really see that PR as necessary. Closing it for now, @hbina feel free to reopen it if you think we're wrong.

Worksheets not sorted when parsing an xls file

Closing as fixed in #275

bump quick-xml to version 0.22

Thanks!

Performance issue with the try! macro

While I am surprised with the drop in performance using `?` (thanks for reporting it), I agree with the others that I'd rather lose *some* performance but ensure I'm not...

How to get "sheet" directly from buffer of bytes?

Closed with #256

[BUG]: XLSB reader panic`s on some Named Ranges

Closing as I cannot reproduce. It has probably been fixed since then.