Johann Tuffe

Results 173 comments of Johann Tuffe

We could add something like this as a `Config` option (I'd prefer the default code not to have it personally). I don't get the `static` lifetime constraint. We do not...

> Procedural macros might also be considered for implementing MessageWrite::get_size I believe that eventually all codegen could be replaced by a custom derive. That said, I am no expert and...

Indeed it is not supported for the moment and there is no short term plan to support it (*support* goes beyond simple protobuf serialization/deserialization). On the other hand, I'd be...

I am not a big fan to be honest, I believe it doesn't fit too well with rust. I *think* i prefer a trait based approach, or even a sync...

I believe you're writing the message length first with quick-protobuf but not with the other libs (you are calling [`serialize_into_vec`][1] or [`Writer::write_message`][2] instead of [`MessageWrite::write_message`][3] directly). Can you show me...

Can you show how you read the message?

Yes, could be a good starting point

This is something I'd like to work on as well. I have to re-learn serde because it's been a long time I haven't used it. Now that it has reached...

This is a good idea!

> That would add a fair bit of complexity to the codegen. Wouldn't it be just replace `WriterBackend` with `std::io::Write` and change the `use ...` at the top? In terms...