Johann Tuffe comments

Results 173 comments of


                                            Johann Tuffe

Implement API to open workbook from bytes

Thanks a lot and sorry for the time it took to merge.

failed to download binaryen-version_90-x86-windows.tar.gz

I have the same error. For now I've disabled optimization by adding this in my Cargo.toml ```toml [package.metadata.wasm-pack.profile.release] wasm-opt = false ``` I hope someone give a proper answer.

Declared entity is not recognized

Indeed quick-xml doesn't support parsing DOCTYPE for the moment. I'd be happy to review a PR but I believe this is not a trivial change. One way you could work...

Disable `trim_text` in Deserializer from_reader

There are very little customization on the serde deserializer so far. I don't think there is any major blocking point, someone just needs to write it.

serde untagged enums are broken

Thanks for commenting it!

Reader Namespaces at the current level

Would you mind writing a PR?

Newlines in attributes are lost

This is indeed looks like a bug.

Bug in writing XML with indents

Thanks for reporting this. Marking it as bug.

quick_xml::se::to_string returns a DeError

Yes. Mind doing a PR?

Invalid files silently succeed

> The empty file (produces just Eof) I think this is a correct behavior. For the rest I agree we should add additional checks on event orders.