Paul Donald

Results 964 comments of Paul Donald

friendly ping to @nbd168 for wifi crypto changes

Recommend revising commit message. Compare with previous commits in this repo. Details from https://github.com/openwrt/netifd/pull/60#issuecomment-3533693220 would do well in the commit message.

`Works togetherwith`. Otherwise, better.

local declarations are anyway undefined in ash, though possibly good practice.

I figure it's to do with `noprefixroute`. Was that delivered via upstream DHCPv6?

You might be onto something. I can say this, however: PD is intended to distribute /64 prefixes, especially those from upstream. But a /64 should be distributed based on your...

If some download is ongoing, and aborts, the user will retry. LGTM.

Looks like a useful tool - but it won't be accepted until it is converted to js.

Look around at how other apps and mods in this repo are done in js. Especially recent ones. Don't be afraid to make a draft PR and get early feedback...