luci icon indicating copy to clipboard operation
luci copied to clipboard

<tcnetemui> include 'tcnetemui' package in luci repository

Open taisinoneka opened this issue 2 years ago • 3 comments

Hi, I have created this tools https://github.com/taisinoneka/tcnetemui It provides GUI for setting NetEm conditions. I have been able to create a package and install it manually. I'd like to work further on this app to include it in luci codebase. What are the next steps for me? Note - it is written in Lua using luci-compat dependancy.

taisinoneka avatar Jan 23 '24 09:01 taisinoneka

Looks like a useful tool - but it won't be accepted until it is converted to js.

systemcrash avatar Jan 25 '24 03:01 systemcrash

Thanks @systemcrash, I'll try my best to rewrite it to js. Anything else I should take into consideration?

taisinoneka avatar Jan 25 '24 08:01 taisinoneka

Look around at how other apps and mods in this repo are done in js. Especially recent ones.

Don't be afraid to make a draft PR and get early feedback and force-push updates to its dev branch.

systemcrash avatar Jan 26 '24 01:01 systemcrash

Closing this as there's nothing actionable. Feel free to open another issue or PR if you want to move forward with a JavaScript version.

jow- avatar Apr 20 '24 21:04 jow-