Paul Donald

@agneevX can you view the dev console and look at the constructed HTML, and look in the `.videoSubtitles` element and its content when you see double?

Note to self: do we want a configure tuneable? Or do we just set `client_addr_reg_enable` to true only if M or O flags are set. `The client SHOULD NOT send...

> * I think that there's no check that the to-be-registered address is of global scope? (GUA/ULA) You're right. There is not (yet). The spec defines no server behaviour for...

OK @Alphix last commit addresses 'exactly one' and: > * I think you should add a bool to `struct dhcpv6_lease` to indicate that this is a self-registered address and not...

Thanks for the comprehensive review @Alphix. This already feels like a better result. If those last few changes look good - then I'll squash. This is the on_link check https://github.com/openwrt/odhcpd/blob/03c1468355c0ffb8fa965cdf57f0d3fc8f01f006/src/dhcpv6-ia.c#L902-L934...

The good news is that most of this is structurally correct, and almost worked on the first try (I got the replies but IA Addr was missing from response because...

Yeah, my solution at present is just to jam the peer IP in there (if checks pass), since this RFC mandates the IP Addr == sender addr. Now the ubus...

OK - the exchanges work with this, although the lease handling is still not yet ready.

Implemented in 6c. Easiest way to test.

OK - I've been testing this one out against 6c, and it works fine: odhcp6c request ``` DHCPv6 Message type: Address Registration Inform (36) Transaction ID: 0x793fe6 Client Identifier Option:...