Paul Donald
Paul Donald
Advise you reword commit message: `Also negation with '!' at the beginning to block every MAC not in the range is possible.` to `Also negation with '!' at the beginning...
Handle could be ambiguous depending on the action requested. The initial wording of ! == block (within the range) is clear and concrete. Less cognitive load.
One potential pitfall with ambiguity: it becomes difficult to differentiate between MAC and hyphen separator when the MACs themselves use hyphen - between octets. :) `00-11-AA-00-00-00-00-11-AA-FF-FF-FF`. Although I can't think...
> I think `-` is more intuitive. Agreed. Just happier that we at least discussed the potential problem here.
Any maintainer can.
@ckorber Recommend tweaking the commit message a bit to e.g. So this is now possible: ``` option src_mac '00:11:AA:00:00:00-00:11:AA:FF:FF:FF' ``` In addition to the original: ``` option src_mac '00:11:AA:00:00:00' ```
Hi @robimarko could we get this in for 25?
I might be able to add some more info to this: when the 'loading' rotating icon is (still) showing when attempting to fetch subtitles (while in playback already) and multiple...
While I wouldn't consider it a major issue, it can be distracting, especially if there are rows of large text obscuring the media you're watching :)
Would be good if everyone on this issue can take the linked commit for a spin, to test whether it also resolves the issue for you. Check out this repo....