Paul Donald

Results 964 comments of Paul Donald

> In isc-dhcp we use explicit blocks for MX, SRV, CNAME, etc. why not do the same? Could you point to specific lines? Or did you miss what this does?...

> what sort of RR’s are you anticipating? https://forum.openwrt.org/t/resolving-query-type-65-to-local-address-for-ios-clients-in-dnsmasq/179504/11

> So in this case, I would probably write something along this lines: Suitable. Included. Also renamed `dnsrr` to `rrname` to align better with the parameters on manpage (context is...

Can we get some more reviews or an approval here?

> Version bump on `PKG_RELEASE`? That thing is so dynamic right now, this PR will quickly get outdated :D

Closing in favour of #14975 Grateful if you could put your approval there @ynezz

> NACK from my side. > > We should not update package to more recent major versions in the stable branch without real reasons. > > The legacy ethtool interface...

> What is the difference with this PR #14929 except for the fact there is a[ second commit there](https://github.com/openwrt/openwrt/pull/14929/commits/338da54d44143015a7f5ccd5786772bf7a37d08b). Maybe it's for the main branch but the changed code is...

Some test build targets have been a bit borked recently, and I'm not sure whether it's because of that or actually something with this PR. Eg. arm: ``` Package kmod-crypto-nhpoly1305...