dnsmasq: add DNS-RR types (add arbitrary resource records)
Tested on 22.03.5
Can set the review ball rolling with @pprindeville @vgaetera @jow-
In isc-dhcp we use explicit blocks for MX, SRV, CNAME, etc. why not do the same?
I would use a case and exact globs matching those patterns.
"and combinations thereof" is the overarching match. Or do you imagine something different?
I would use a case and exact globs matching those patterns. "and combinations thereof" is the overarching match. Or do you imagine something different?
Like what sort of patterns?
In isc-dhcp we use explicit blocks for MX, SRV, CNAME, etc. why not do the same?
Could you point to specific lines? Or did you miss what this does? dnsmasq already handles those specific cases, but it also handles dns-rr for those types not yet understood by dnsmasq.
already handles those specific cases, but it also handles dns-rr for those types not yet understood by dnsmasq.
what sort of RR’s are you anticipating?
what sort of RR’s are you anticipating?
https://forum.openwrt.org/t/resolving-query-type-65-to-local-address-for-ios-clients-in-dnsmasq/179504/11
Can you review?
@neheb @BKPepe
So in this case, I would probably write something along this lines:
Suitable. Included. Also renamed dnsrr to rrname to align better with the parameters on manpage (context is more clear).
Can we get some more reviews or an approval here?
Version bump on
PKG_RELEASE?
That thing is so dynamic right now, this PR will quickly get outdated :D
Closing in favour of #14975 Grateful if you could put your approval there @ynezz