openwrt icon indicating copy to clipboard operation
openwrt copied to clipboard

dnsmasq: add DNS-RR types (add arbitrary resource records)

Open systemcrash opened this issue 2 years ago • 10 comments

Tested on 22.03.5

Can set the review ball rolling with @pprindeville @vgaetera @jow-

systemcrash avatar Dec 23 '23 19:12 systemcrash

In isc-dhcp we use explicit blocks for MX, SRV, CNAME, etc. why not do the same?

pprindeville avatar Dec 23 '23 19:12 pprindeville

I would use a case and exact globs matching those patterns.

"and combinations thereof" is the overarching match. Or do you imagine something different?

systemcrash avatar Dec 23 '23 19:12 systemcrash

I would use a case and exact globs matching those patterns. "and combinations thereof" is the overarching match. Or do you imagine something different?

Like what sort of patterns?

pprindeville avatar Dec 23 '23 20:12 pprindeville

In isc-dhcp we use explicit blocks for MX, SRV, CNAME, etc. why not do the same?

Could you point to specific lines? Or did you miss what this does? dnsmasq already handles those specific cases, but it also handles dns-rr for those types not yet understood by dnsmasq.

systemcrash avatar Dec 23 '23 23:12 systemcrash

already handles those specific cases, but it also handles dns-rr for those types not yet understood by dnsmasq.

what sort of RR’s are you anticipating?

pprindeville avatar Dec 24 '23 20:12 pprindeville

what sort of RR’s are you anticipating?

https://forum.openwrt.org/t/resolving-query-type-65-to-local-address-for-ios-clients-in-dnsmasq/179504/11

systemcrash avatar Dec 25 '23 01:12 systemcrash

Can you review?

@neheb @BKPepe

systemcrash avatar Jan 05 '24 19:01 systemcrash

So in this case, I would probably write something along this lines:

Suitable. Included. Also renamed dnsrr to rrname to align better with the parameters on manpage (context is more clear).

systemcrash avatar Jan 08 '24 13:01 systemcrash

Can we get some more reviews or an approval here?

systemcrash avatar Mar 16 '24 22:03 systemcrash

Version bump on PKG_RELEASE?

That thing is so dynamic right now, this PR will quickly get outdated :D

systemcrash avatar Mar 18 '24 14:03 systemcrash

Closing in favour of #14975 Grateful if you could put your approval there @ynezz

systemcrash avatar Mar 27 '24 00:03 systemcrash