Paul Donald
Paul Donald
ping @ynezz @981213
@BKPepe Please update your review ping @ynezz @981213
The weasel word there is "should". No discussion or vote raised.
> and there was a public discussion ([1/2024](https://lists.openwrt.org/pipermail/openwrt-devel/2024-January/042058.html)) Then evidently the following is erroneous and it should be reverted (revert the revert): > @systemcrash FYI [openwrt/actions-shared-workflows@12d9551](https://github.com/openwrt/actions-shared-workflows/commit/12d9551f2d07ec34ac813da8612c8014fb393af6)
And *this* PR can be merged
> I think, @nbd168 wants to do vote, which is done on openwrt-adm, when they are voting about adding new people to the core team. I see no desire. Writing...
So @one-d-wide I propose that while everyone is *really busy* trying to get a vote off the ground, in the meantime you adopt some official looking pseudonym, like One D...
Dropbox? Or dropbear?
The word 'should' is doing a lot of lifting here.
Shouldn't `proto_pppoe_setup()`call to `ppp_generic_setup()` pass `mtu` also? https://github.com/openwrt/openwrt/blob/f1de1a090fadc74504b3ee1b5bcb914c9110bc6f/package/network/services/ppp/files/ppp.sh#L219-L242