Paul Donald
Paul Donald
@jow-: for pppoe "should" is false. The MTU option needs to apply to the 'ethernet' interface responsible for the connection, if there is one. The manpages for the `pppoe.so` module...
See also https://github.com/openwrt/openwrt/pull/15176
I run into this now from time to time. I only see it because I cranked up logging defaults. I'm on macOS 10.15.7. Things seem to work out anyway, and...
Yo, can we get some movement on this PR please?
@meteozond Please fix the commit formalities ( SOB line and don't include a merge commit, just rebase from master )
I think it's fine. In @rmilecki absence, other reviewers can approve.
"Sneaking around" 😆 > Sneaking around with additional variables next to function arguments obviously isn't very nice. I'm not a committer, but I'd just add an additional function. Since procd_add_mdns()...
> passing everything as arguments would be nicer. Ah, got it. Appending an extra parm in the call and shifting the call param array. Would you approve this PR as...
Does this get merged or what?
> > I would use a case and exact globs matching those patterns. > "and combinations thereof" is the overarching match. Or do you imagine something different?