syeopite

Results 192 comments of syeopite

> We're switching to GNU gettext PO files. We should use MO files; parsing and reading binary files should be much faster than parsing text.

> That's why switching to gettext was important, to support plural forms (1 hour / 2 hours). I was actually thinking of some some other language feature, unique to time...

> ...wouldn't it be better to use a very generic dataset (maybe YAML, with converters to JSON, TOML, XML and others) that... You literally just defined CLDR lol. [It's a...

For supporting transcripts there's [videojs-transcript](https://github.com/walsh9/videojs-transcript) though it doesn't appear to be maintained.

Yep transcripts are great for that. --- Since the issue opened in 2021, the logic for requesting transcripts has been added to the code to be used as a workaround...

I've finished implementing a basic transcripts feature into Invidious. ![transcript implementation](https://github.com/iv-org/invidious/assets/70992037/5553d6db-ebdc-45ef-8f8f-348ca587195a) You can find the code over at my branch here https://github.com/syeopite/invidious/tree/transcripts-support The feature is pretty much done but I'd...

It seems like #4439 fixes the issues with enabling the quality selector on HLS videos! Livestreams are still not supported however.

Your PR is fine. We're just lacking the manpower and time to review everything :(

Considering this basically rewrites the entire parser I wouldn't exactly consider this PR to be a small change.

Fair enough. I've went ahead and unnested it along with the modified object in order to reflect iv-org/documentation#76