instances-api icon indicating copy to clipboard operation
instances-api copied to clipboard

Rewrite parser for iv-org/documentation#76

Open syeopite opened this issue 4 years ago • 4 comments

This PR rewrites the parser to account for iv-org/documentation#76.

All new fields added by said PR has been added as well. NEW

This PR also contains the code from #29.

syeopite avatar Jun 19 '21 14:06 syeopite

I wouldn’t introduce breaking change for such a small thing. Just add a new field

B0pol avatar Jun 19 '21 14:06 B0pol

Considering this basically rewrites the entire parser I wouldn't exactly consider this PR to be a small change.

syeopite avatar Jun 19 '21 14:06 syeopite

I’m talking about the "country" object. Why don’t you add a new field instead of adding a breaking change and moving two fields?

B0pol avatar Jun 19 '21 14:06 B0pol

Fair enough. I've went ahead and unnested it along with the modified object in order to reflect iv-org/documentation#76

syeopite avatar Jun 27 '21 19:06 syeopite