Results 408 comments of Sebastian Wick

It should throw an error because the configuration is nonsensical instead of getting ignored silently.

Is anyone trying to get this into flathub? It's currently depending on an unsupported runtime which isn't great.

@mjog can this MR be closed then?

It is questionable if we want to have such a portal, and the code is severely outdated, so I'm closing this PR. Feel free to re-open a discussion about a...

> My suggestion would be drop the requirement that no other call to the portal can happen before registering. This would mean we will have inconsistent state. I'm not entirely...

@Sodivad did you end up solving this in the toolkit or is this still an issue?

Should be split in a few commits but LGTM in general, open questions notwithstanding.

Fixed two issues that ShellCheck uncovered. The rest are false-positives and patterns used in all other tests.

Fixed a bug where the first time flatpak preinstall is run, we would mark failed installs as pre-installed.

AppArmor restrictions make CI skip test involving bwrap. That required me to fix the tests to work without bwrap in this PR. Over in https://github.com/flatpak/flatpak/pull/6284 the restriction is removed. It...