Sebastian Wick

It's still on my list but I'm also busy with HDR stuff currently. If you have any question, feel free to reach out.

I like the idea that requests from unidentified apps (`app_id == ""`) shall always prompt the user. I do however think that we should only make changes in that direction...

The commit message needs to change a bit as well, something along the lines of `openuri: Improve the documentation of OpenDirectory/OpenFile`

No response in a year. I opened a new PR based on the idea here: https://github.com/flatpak/xdg-desktop-portal/pull/1795

Pushed a branch with a bunch of cleanups and changes I'd like to see https://github.com/swick/xdg-desktop-portal/commits/wip/usb-portal-fixes1/ But in general this LGTM. The biggest issue is the lack of tests IMO. Some...

I started working on python tests for this portal here: https://github.com/swick/xdg-desktop-portal/commits/wip/usb-portal-tests/ It's based on the PR which tests the location portal with the python tests because it already has a...

Some prepwork for the testing is up in a PR: https://github.com/flatpak/xdg-desktop-portal/pull/1477 Also update the branch https://github.com/swick/xdg-desktop-portal/commits/wip/usb-portal-tests/ which now has passing tests with some mocked devices. It could use some more...

I think I saw a race in the test removing a device. Maybe you can force it by adding and then removing a bunch of devices and repeating the test.

FWIW, with `podman run --rm -ti -v .:/portal:z ghcr.io/hfiguiere/xdg-desktop-portal:20241024-3 bash` I can reproduce the failure locally.

> It never receives the device event for removal. Still work locally. I can even receive it twice. In the current PR the signal is connected twice so I guess...