Mikołaj Świątek

The reason I marked that as a painful breaking change is that the field is immutable, and changing it would require the controller to recreate the Deployment. See https://github.com/open-telemetry/opentelemetry-operator/pull/2455/files#r1433035505 for...

That sounds like a fix we can easily do without breaking anything, yes.

Could we use `manifestutils.Labels` for these?

I believe this issue belongs in https://github.com/open-telemetry/opentelemetry-operator. The prometheus receiver doesn't interact with ServiceMonitors in any way - in the otel ecosystem, the Target Allocator does this.

As per the documentation, `serviceMonitorSelector` is a simple map of label name to label value, so what you did here: ```yaml serviceMonitorSelector: matchLabels: "lightstep-metrics-collector" #"translation-service-monitor" # "document-translation" # "nmt-engines-monitor" #...

@yuriolisa that change is only internal for now, this issue will be resolved in `v1alpha2` CRDs.

This is a bit tricky, as this substitution is done by config reloader in prometheus-operator managed configurations. See: https://github.com/thanos-io/thanos/blob/main/pkg/reloader/reloader.go#L82. This means that the variables are substituted in Prometheus' environment, which...

#1875 is not enough to resolve this issue. It did add the ability to define env variables in the Target Allocator, but not variable expansion for the configuration.

I'm guessing we just inherited it from kubebuilder? If it doesn't exist, we should delete it.

Looks like dashes are not allowed in feature gate ids in 1.0.0. We'll need to remove the two feature gates we have that use them before we can merge this....