Mikołaj Świątek

Results 312 comments of Mikołaj Świątek

> This shows the current state, which is good, but does not give any way to keep this up to date. That's definitely not going to happen in this PR....

Moving this to v5, as it has unknown and potentially significant consequences for both customer content and Sumo Apps. Needs more investigation.

I agree in spirit. The target allocator integration should be owned by the codeowners of the target allocator itself, which in principle includes some combination of @open-telemetry/operator-ta-maintainers and @open-telemetry/operator-maintainers. I...

> Can you fix CI? After that I am happy to merge this Rebased on main after #10661, should be enough.

I think this is because `k8s.container.name` is not actually added to pod attributes that association can check. If so, this should either be documented, or ideally should result in an...

@TylerHelmuth I don't think this works either way. If you look at the [implementation](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/c38ec5cab617bd7a83b82d66be69c62019da6987/processor/k8sattributesprocessor/internal/kube/client.go#L797) of Pod cache updates, it goes like so: 1. Extract Pod attributes (but not container attributes)...

The test failure looks transient, they pass locally for me.

I'd like to understand what the problem is exactly. Is it just the conversion webhook misbehaving, or *all* of them? The latter will be very confusing, as the changes in...

@parkedwards just to be sure I understand correctly, you upgrade the operator chart to `0.58.2`, and then you get the error when trying to apply `v1alpha1.OpenTelemetryCollector` resources? Can you also...